Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Attributes Scenario 2: Write badly cased attributes. Remove most of whitelist. #10385

Merged
merged 49 commits into from
Aug 15, 2017
Merged

Custom Attributes Scenario 2: Write badly cased attributes. Remove most of whitelist. #10385

merged 49 commits into from
Aug 15, 2017

Commits on Aug 10, 2017

  1. Allow custom attributes. Add flag to toggle custom attribute behavior

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    af36bfa View commit details
    Browse the repository at this point in the history

  2. Update custom attribute logic 

    - Only allow string attributes
- Remove custom attribute feature flag
- Add additional tests for data, aria, and custom attributes
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    601eabd View commit details
    Browse the repository at this point in the history

  3. Allow numbers and booleans custom attributes. Cut isCustomAttribute

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    eab17b5 View commit details
    Browse the repository at this point in the history

  4. Cover objects with custom attributes in warning test

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    137af3b View commit details
    Browse the repository at this point in the history

  5. Rename DOMProperty.isWriteable to shouldSetAttribute

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    55e55ba View commit details
    Browse the repository at this point in the history

  6. Rework conditions in shouldSetProperty to avoid edge cases

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    2106844 View commit details
    Browse the repository at this point in the history

  7. Update unknown property warning to include custom attribute information

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    9caa863 View commit details
    Browse the repository at this point in the history

  8. Remove ref and key from reserved props

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    84beb33 View commit details
    Browse the repository at this point in the history

  9. Ensure SSR test coverage for DOMProperty injections

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f406aac View commit details
    Browse the repository at this point in the history

  10. Add ajaxify attribute for internal FB support

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    da19306 View commit details
    Browse the repository at this point in the history

  11. Ajaxify is a stringifiable object attribute

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f09d3f3 View commit details
    Browse the repository at this point in the history

  12. Update test name for custom attributes on custom elements

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    aeb2db3 View commit details
    Browse the repository at this point in the history

  13. Remove SSR custom injection test

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7cbf2f3 View commit details
    Browse the repository at this point in the history

  14. Remove onAfterResetModules hooks in SSR render tests

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    b67dd13 View commit details
    Browse the repository at this point in the history

  15. Do not allow assignment of attributes that are aliased

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    dab72d2 View commit details
    Browse the repository at this point in the history

  16. Update custom attribute test to check value, not just presence

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    000c0df View commit details
    Browse the repository at this point in the history

  17. Address case where class is assigned as an attribute on custom elemen… 

    …ts. Improve SSR tests
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    a77d47b View commit details
    Browse the repository at this point in the history

  18. Cover cases where className and for are given to custom elements

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f661d22 View commit details
    Browse the repository at this point in the history

  19. Remove unnecessary spys on console.error. Reduce extra space in tests

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    aa3916b View commit details
    Browse the repository at this point in the history

  20. Cover cased custom attributes in SSR tests

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    6ce3335 View commit details
    Browse the repository at this point in the history

  21. Custom attributes are case sensitive

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    a11b0bd View commit details
    Browse the repository at this point in the history

  22. Allow uppercase letters in custom attributes. Address associated edge… 

    … cases
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    07c6865 View commit details
    Browse the repository at this point in the history

  23. Make ARIA enforcement dev-only

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    599844e View commit details
    Browse the repository at this point in the history

  24. Remove non-case sensitive standard attributes. Make ARIA hook dev only.

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    14d5ea0 View commit details
    Browse the repository at this point in the history

  25. Remove case sensitive props

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    99206db View commit details
    Browse the repository at this point in the history

  26. Add back a few attributes and explain why they are needed

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    a3c2aef View commit details
    Browse the repository at this point in the history

  27. Remove possibleStandardNames from DOMProperty.js

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    ca601c6 View commit details
    Browse the repository at this point in the history

  28. Fix typo in HTMLPropertyConfig comment

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    3e866cf View commit details
    Browse the repository at this point in the history

  29. Remove duplicative comment

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    b7d6996 View commit details
    Browse the repository at this point in the history

  30. Add back loop boolean property

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    545bcab View commit details
    Browse the repository at this point in the history

  31. Allow improperly cased aliased attributes. Add additional tests

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    afb609e View commit details
    Browse the repository at this point in the history

  32. Handle special properties like onFocusOut

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    71871c4 View commit details
    Browse the repository at this point in the history

  33. Add some comments to document where casing matters. Remove DOMPropert… 

    …yNames
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    3281320 View commit details
    Browse the repository at this point in the history

  34. Fix spelling mistake in ajaxify HTML property comment

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    19bfbaf View commit details
    Browse the repository at this point in the history

  35. Remove alias test that covers multiple aliases for one property

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    6df8b4f View commit details
    Browse the repository at this point in the history

  36. Fix typo in comment

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    cb57075 View commit details
    Browse the repository at this point in the history

  37. Build SVG aliases dynamically

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    21678fc View commit details
    Browse the repository at this point in the history

  38. Remove unused DOMPropertyNames reference

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    90b4cce View commit details
    Browse the repository at this point in the history

  39. Do not translate bad casings of aliased attributes 

    - classname writes to the DOM as classname
- class does not write to the DOM
- cLASS does not write to the DOM
- arabic-form does not write to the DOM
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    fa3db62 View commit details
    Browse the repository at this point in the history

  40. Revise the way custom booleans are treated 

    - Custom attributes can not have boolean values unless they are aria
  or data attributes
- Attributes with boolean values have been added back to the whitelist
- Warnings now exclude booleans from supported types
- Associated test coverage
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    21db719 View commit details
    Browse the repository at this point in the history

  41. Add developer warnings for NaN and ARIA hooks

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    c2c3d63 View commit details
    Browse the repository at this point in the history

  42. Revert changes to the docs 

    We'll update them separately
    @gaearon @nhunzaker
    gaearon authored and nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7f16b4d View commit details
    Browse the repository at this point in the history

  43. Use string comparison instead of regex to check for data and aria att… 

    …ributes.
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    3908cd3 View commit details
    Browse the repository at this point in the history

  44. Warn about unsupported properties without case sensitivity

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    2479fcc View commit details
    Browse the repository at this point in the history

  45. Remove attributes that are updated to invalid values

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    8162222 View commit details
    Browse the repository at this point in the history

  46. Support object property values with toString methods. Allow boolean p… 

    …rops to coerce objects
    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    e9c8910 View commit details
    Browse the repository at this point in the history

  47. Add back ajaxify test

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    6b1572a View commit details
    Browse the repository at this point in the history

  48. Address bad references in ReactDOMComponent-test. Format.

    @nhunzaker
    nhunzaker committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    cf1b0d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. Allow all objects and pass incorrect aliases

    @sophiebits
    sophiebits committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    b923740 View commit details
    Browse the repository at this point in the history