Wrap warning() calls in a DEV check for RN_* builds too #10428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work done in #10361-
warning
left in the React Native build by auto-wrapping all calls towarning
in an if-DEV check.warning
imports and a call or two in__DEV__
checks in the source just by looking at which ones were removed from the prod bundle after adding this check.allTypesByEventName
) and loop fromsrc/renderers/native/ReactNativeBridgeEventPlugin
.Before and after diffs below.
build/react-native/ReactNativeStack-prod.js
build/react-native/ReactNativeFiber-prod.js
build/react-native/ReactNativeStack-dev.js
build/react-native/ReactNativeFiber-dev.js