-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error to warn of mistaken loading of prod + dev React bundles #10446
Merged
flarnie
merged 11 commits into
facebook:master
from
flarnie:throwWhenMinificationLeavesDeadReactDevCodeBehind
Aug 16, 2017
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8e280c8
Throw error to warn of mistaken loading of prod + dev React bundles
flarnie 441d661
Remove extra 'prod' env. check and add link to docs in error message
flarnie 05be49a
WIP fix and test 'testMinificationUsedDCE' method
flarnie 8fab885
Add babeli and uglifyjs as dev-only dependencies
flarnie 9a73704
Fix typo and add 'uglifyjs' tests
flarnie 5204310
Run prettier
flarnie 26ce0ac
var -> const/let
flarnie 498f8f5
Require specific version of `uglify-js`
flarnie ab6c1f0
Add build step copying testMinificationUsedDCE into build/packages/re…
flarnie 8a1c36b
Inline 'testMinificationUsedDCE' and remove unit test for now
flarnie 0eecddc
Revert unintentional changes to dependency versions, variable placing
flarnie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,36 @@ | ||
'use strict'; | ||
|
||
function testMinification() { | ||
if (testMinification.name === 'testMinification') { | ||
// We are not minified. | ||
// This might be a Node environment where DCE is not expected anyway. | ||
return; | ||
} | ||
if (process.env.NODE_ENV === 'production') { | ||
if (process.env.NODE_ENV === 'development') { | ||
throw new Error('This is unreachable'); | ||
} | ||
try { | ||
const source = testMinification.toString(); | ||
if (source.indexOf('toString') === -1) { | ||
// We know for a fact the above line exists. | ||
// Therefore the browser gave us invalid source. | ||
return; | ||
} | ||
if (source.indexOf('unreachable') !== -1) { | ||
// Dead code elimination would have stripped that branch | ||
// because it is impossible to reach in production. | ||
setTimeout(function() { | ||
// Ensure it gets reported to production logging | ||
throw new Error('React is running in production mode, but dead code elimination has not been applied.'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should probably include "Read how to correctly configure React for production: " and an fame link to "Use the Production Build" in "Optimizing Performance" doc. |
||
}); | ||
} | ||
} catch (e) {} | ||
} | ||
} | ||
|
||
if (process.env.NODE_ENV === 'production') { | ||
testMinification(); | ||
module.exports = require('./cjs/react.production.min.js'); | ||
} else { | ||
module.exports = require('./cjs/react.development.js'); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This outer wrapper is probably unnecessary since we are already calling it from the same condition.