Track nested updates per root #10574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
reviewed
Aug 30, 2017
| @@ -25,6 +25,8 @@ export type FiberRoot = { | |||
| isScheduled: boolean, | |||
| // The work schedule is a linked list. | |||
| nextScheduledRoot: FiberRoot | null, | |||
| // Track nested commits, to prevent an infinite loop. | |||
| nestedUpdateCount: number, | |||
There was a problem hiding this comment.
Needs to be added to createFiberRoot below to prevent deopting.
(Maybe we should add a preventExtensions here like we have in createFiber
.)There was a problem hiding this comment.
Flow also caught this error, I just forgot to run it
sebmarkbage
requested changes
Aug 30, 2017
acdlite
force-pushed
the
tracknestedupdatesperroot
branch
3 times, most recently
from
e1bda91 to
4e6a257
Compare
|
@sebmarkbage Updated |
acdlite
force-pushed
the
tracknestedupdatesperroot
branch
from
4e6a257 to
6a65f92
Compare
We track nested updates to simulate a stack overflow error and prevent infinite loops. Every time we commit a tree, we increment a counter. This works if you only have one tree, but if you update many separate trees, it creates a false negative. The fix is to reset the counter whenever we switch trees.
acdlite
force-pushed
the
tracknestedupdatesperroot
branch
from
6a65f92 to
883f9f5
Compare
sebmarkbage
approved these changes
Aug 31, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track nested updates to simulate a stack overflow error and prevent infinite loops. Every time we commit a tree, we increment a counter. This works if you only have one tree, but if you update many separate trees, it creates a false negative.
The fix is to reset the counter whenever we switch trees.