Share Object.assign polyfill between UMD builds #10671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wins back 0.3k post min/gzip which we lost due to adding license headers 😛 We can later share more utilities like this, since currently it's suboptimal that some
fbjs
things are duplicated. This only affects UMD builds.How I verified it works:
index
toassign
though (since Rollup gives it a different name now)It only affects UMD builds and doesn’t affect any other builds.
This is not global shared state, it's just manual deduplication.