Update value tracking on cousin radios

[jquense]

fixes #10739

I’m not sure how this managed to not get fixed in the last PR. I updated the fixture to ensure that its fully testing whether the regression is fixed. Unfortunately
it means that 15.6.2 didn’t get this fix, do we call it at this point or what is the policy on releasing fixes on previous majors?

[reactjs-bot]

Deploy preview ready!

Built with commit 7230e62

https://deploy-preview-11028--reactjs.netlify.com

[gaearon]

Flow fails:

$ node ./scripts/tasks/flow
Error: src/renderers/dom/shared/inputValueTracking.js:19
 19: type ElementWithValueTracker = HTMLInputElement & WrapperState;
                                                       ^^^^^^^^^^^^ property `_valueTracker`. Property not found in
333:       inputValueTracking.updateValueIfChanged(otherNode);
                                                   ^^^^^^^^^ HTMLInputElement. See: src/renderers/dom/fiber/wrappers/ReactDOMFiberInput.js:333

Unfortunately it means that 15.6.2 didn’t get this fix, do we call it at this point or what is the policy on releasing fixes on previous majors?

Was it always broken or did it regress in 15.6.0? If it fixes a regression I guess we'll have to cut 15.6.3. But we need to make sure the fix is solid.

[jquense]

This is was a regression in 15.6.0 yeah. grr flow, sorry about that, i have to much trust that my vscode will surface an issue :P

I've love to ensure that this solid, any other thoughts on acceptance criteria for that? We'll do the full fixture test run on it of course (not that that helped last time), more context here: #10186 (comment)

[gaearon]

Do we have a post mortem on why fixtures didn't catch this?

[aweary]

do we call it at this point or what is the policy on releasing fixes on previous majors

I think this would warrant another 15 patch release. IIRC we've done patch releases for a previous major before.

[jquense]

Do we have a post mortem on why fixtures didn't catch this?

Not entirely, I don't see much suggesting that something changed since the PR that broke it again, but idk. My hunch is that it's because the fixture was incomplete. It only asked to tests for 2 change events, the last fix essentially added one more change event where their wasn't one, but stopped there. so:

• originally: you got one change event e.g initial selected A -> B worked, but not B -> A
• first fix: A -> B -> A worked (2 events) but not A -> B -> A -> B
• this one: all events fire

[jquense]

gonna fix this up. anyone want to do a bit more testing in addition to what I've done or we feel good about this?

[jquense]

ping before 16.1.0 happens

[jquense]

(I still need to rebase sorry)

[nhunzaker]

@jquense I'll do some QA on this, but I can't get to it until later today.

Still I'd like to get this merged in soon.

[nhunzaker]

Works in:

Firefox 47, 57
Safari 7.1, 8, 9, 10.1, 11
Chrome 42, 43, 44, 62
IE 9, 10, 11
Edge 16
iOS 8.4, 10.2, 11

On an unrelated note, the click event test fixtures fails in:

Safari 7.1, 8, 9
iOS Safari 8.4
Chrome 42

I'll file a separate issue for that, even if it's to conclude that we don't care (#11560)

[nhunzaker]

@jquense This works well for me. Please merge at your leisure.

I would lobby heavily for this to hit 15.x. This effects multiple of the apps that I maintain, and the only option in the short term is to down-grade to 15.4.0.

I'll even nominate myself to take on the work of cutting that release if it means anything.

[nhunzaker]

Oh, and I ran prettier for you, so this should pass CI soon :)

[gaearon]

I think it is extremely unlikely we'll do another 15.x at this point.

[gaearon]

Looking at the fix though it does seem pretty small. If we broke it and you're willing to cut 15.6.4 and more in case it adds further breakage then maybe. :-)

[jquense]

thanks team! A 15.6.4 would benefit me as well if we can swing it, @nhunzaker let me know if I can help with that

[nhunzaker]

Awesome. I'll write up a check list. I'd also like to run it locally on a few of our apps at work and verify everything is 👌 in real apps, then circle back to the test fixtures with any mishaps.

[nhunzaker]

The first thing to do is send this out to 15-dev. @jquense is that something you are comfortable taking on?