Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10987 which is a regression in 16.
Verified with a new integration test, and by manually trying https://github.com/forWorkAtML/svg-bug.
Why it broke: we removed most of the DOM whitelist recently (#10385), and
tabIndex
was one of the attributes that got nixed because its lowercase version (tabindex
) "just works". However, we forgot it’s also a valid SVG attribute which is case sensitive.We currently use a different logic branch for attributes that aren't in the whitelist, so it didn't get properly lowercased in 16.0.0. Adding it back to the whitelist forces it to be lowercased, which fixes it for SVG (and doesn't change how it works for HTML).
The way whitelist works is pretty confusing now but I'm going to fix this later in #10805. Let's just patch this hole for now.
I don't expect there to be more regressions like this because it's the only
camelCase
HTML attribute we deleted in #10385 that also happens to apply to SVG.