-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check to deduplicate function type warning calls on each compon… #11120
Added check to deduplicate function type warning calls on each compon… #11120
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Hmm, I've completed the CLA. |
Deploy preview ready! Built with commit 5852b59 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Can you please test it too? You can take the existing test for it, expand it to render two times and in two places, and then verify that we only saw 2 logs (rather than 4). |
Sure, I'll update it soon |
…duplicated correctly by component type
I've added test checking deduplication of warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this tests deduplication. You'd need to render twice to verify it works.
… React child' warning so it will check against rerendering component now
Yeah, my bad, sorry. I've added rendering of component twice to the test. |
Looks great. Thanks! |
Hey, I've added check to avoid duplication of messages 'Functions are not valid as React child...' for same component type.
Also, this is my first PR in React, yay.