Allow custom attribute named on to be passed on to elements
#11153
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
@facebook-github-bot Thank you dear bot. Email sent! |
|
Hm, but then since we are on server side rendering, shouldn't this check prevent the need for the fix above - taken that the regex is loosened a bit? Not sure how could I avoid the loading of any event plugin though, so the condition would pass. That will allow us to attach Or maybe that would be a total misuse of that condition.. so yeah, any input would be really much appreciated. Cheers |
| spyOn(console, 'error'); | ||
| var container = document.createElement('div'); | ||
| ReactDOM.render(<amp-image on="tap" />, container); | ||
| expectDev(console.error.calls.count()).toBe(0); |
There was a problem hiding this comment.
You don't need this (or spyOn call). By default we assume none of the tests warn unless they opt in.
There was a problem hiding this comment.
Instead you'll want to assert that the on attribute gets set (which it probably doesn't right now).
|
If you add an assertion about attribute presence, you'll probably see that this just silenced the warning but doesn't actually affect the output. I think the real place to change this behavior is here. |
|
Thanks, I'll prepare something. |
|
Also, |
|
@gaearon Something like this? |
| @@ -205,7 +205,8 @@ var DOMProperty = { | |||
| } | |||
| if ( | |||
| (name[0] === 'o' || name[0] === 'O') && | |||
| (name[1] === 'n' || name[1] === 'N') | |||
| (name[1] === 'n' || name[1] === 'N') && | |||
| name.toLowerCase() !== 'on' | |||
There was a problem hiding this comment.
Can we just check name.length instead?
|
If this is only meant for custom elements, why are we testing with a DIV? |
|
As I realised afterwards, in AMP it is also needed for standard elements as well, for example: That should not have any implications though, right? I will update the PR title, so it reflects it. |
nuc
changed the title
on property for custom elementson to be passed on to elements
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Seems legit. |
|
React |
|
@gaearon It works great. Thanks guys! |
Hi there,
It seems that currently is not possible to pass a custom property named
onon custom components.We would like to render AMP pages on the server, in which you define the event handlers like so:
<amp-image on="tap:do-something" />.In order to do so, I made the check a bit more specific, to allow the property to be passed if it's just named
on.Even though the tests are passing, please let me know if that would be the right approach.
Thanks,
Georgios