Update Jest and remove hacks #11372
Merged
Update Jest and remove hacks #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were fixed by jestjs/jest#4761.
I changed them to absolute to work around a Jest bug. The bug has been fixed so I can revert my past changes now.
gaearon
commented
Oct 26, 2017
| @@ -53,6 +53,7 @@ | |||
| "eslint-plugin-flowtype": "^2.25.0", | |||
| "eslint-plugin-react": "^6.7.1", | |||
| "eslint-plugin-react-internal": "file:./scripts/eslint-rules", | |||
| "expect": "^21.3.0-beta.4", | |||
There was a problem hiding this comment.
jest-matchers was renamed to expect.
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Update Jest * Remove hacks for Jest + Workspace integration They were fixed by jestjs/jest#4761. * Use relative requires in tests relying on private APIs I changed them to absolute to work around a Jest bug. The bug has been fixed so I can revert my past changes now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a Jest + Yarn Workspaces integration bug in jestjs/jest#4761.
This lets us remove the hacky transform whitelist, and use relative requires in tests again.