Release script follow-up work after 16.1.0-beta release #11437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
changed the title
gaearon
reviewed
Nov 3, 2017
| (dry ? ' --dry' : ''); | ||
|
|
||
| const packagingFixturesPath = join(cwd, 'fixtures/packaging'); | ||
| const standaloneFiturePath = join( |
gaearon
reviewed
Nov 3, 2017
| suffix = `-${prerelease.join('.')}`; | ||
| } | ||
|
|
||
| json.version = `0.${semver.minor(json.version) + 1}.0${suffix}`; |
Collaborator
There was a problem hiding this comment.
Not sure I understand the difference between when to use version and when to use json.version.
If I do two pre-releases in a row, does this increment minor once or twice? If it only increments once then sounds fine.
Contributor
Author
There was a problem hiding this comment.
version is coming from the user's CLI param (eg 16.0.1-beta)
The "version" in package.json will typically be the same, except for < 1.0 releases like the reconciler, when we'll increment the major (eg 0.1.0 -> 0.2.0) and now also append the prerelease suffix (eg 16.1.0-beta -> 0.2.0-beta).
Contributor
Author
There was a problem hiding this comment.
I'll update the inline comment to be clearer.
gaearon
approved these changes
Nov 3, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Seems good. See minor comments above.
5 tasks
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Build script creates git tag * Build script post instructions print better relative paths * Pre-release (<1.0) version numbers also include pre-release suffix (eg '-beta.0') * Post-NPM-publish step properly handles minor rev comparison check * Release script also updates @next tag when publishing @latest * Fixed a typo. Improved inline comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves remaining items from #11435.
Commits are atomic.