Fix to reset the forceUpdate flag after the update #11440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have commented this to the PR. |
|
Thanks for catching this. I decided to restructure the code a bit to better match how we do it in the real reconciler. Also added support for |
|
Thanks! 👏 I forgot about PureComponent! 😅 |
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Fix to reset the forceUpdate flag after the update * Add support for PureComponent and mirror real behavior closer
This was referenced Feb 2, 2018
Open
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Fix to reset the forceUpdate flag after the update * Add support for PureComponent and mirror real behavior closer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to follow up #11439.
Currently,
_forcedUpdateflag is never reset untilshouldComponentUpdatereturnsfalseso A test in this PR doesn't pass.This is a PR to fix this.
I think the flag can be reset after the render.