Skip to content

Conversation

@timjacobi
Copy link
Member

getEventTarget seemed not to have been tested yet. This PR adds some tests for it.

@gaearon
Copy link
Collaborator

gaearon commented Nov 11, 2017

This is a unit test, which we're trying to avoid. It won't help us if we rewrite the implementation and stop using this helper. Instead we want to have integration tests using public API only.

@timjacobi
Copy link
Member Author

timjacobi commented Nov 11, 2017

Makes sense. Are we thinking about a strategy on how we integration test cross browser inconsistencies? For example having event.srcElement set instead of event.target is quite hard to fake in integration tests. I'm still thinking about whether it is even a good idea to have the test "know" about this inconsistency or if we should instead run the test in an actual browser.

@gaearon
Copy link
Collaborator

gaearon commented Nov 11, 2017

The tests I previously pointed to (#11365) already do this 🙂 please check them out.

@timjacobi
Copy link
Member Author

Alright. I'm gonna close this. Will keep an eye on the migration to public API test. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants