Read debugRenderPhaseSideEffects from GK #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
changed the title
gaearon
approved these changes
Nov 20, 2017
bvaughn
changed the title
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
* Forked ReactFeatureFlags for React Native to enable debugRenderPhaseSideEffects GK * Changed debugRenderPhaseSideEffects in www feature flags to be runtime as well
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Forked ReactFeatureFlags for React Native to enable debugRenderPhaseSideEffects GK * Changed debugRenderPhaseSideEffects in www feature flags to be runtime as well
This was referenced Mar 15, 2021
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Nov 27, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to opt some engineers into this newly-added GK to help identify unsafe side-effects within lifecycle hooks and
setStatecallbacks. This PR adds the ability to determine this value at runtime (rather than static as it is for NPM builds) .Verified that this inserts the following line to the fbsource and www builds:
For the www build, this should be a simple matter of reading this value from the GK module.
I'm not sure yet of the best way to inject it for React Native builds, given that the Rollup build reads the value from
ReactFeatureFlagsduring initialization. We'll have to make sure that app code injects beforeReactNativeis initialized. I believe this should be possible, but it may depend on how we hoist requires in that environment.