Consolidate all symbols in a single file #11629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the code duplication as we have quite a few of them now. It's also nice to be able to see them all together. Note this is
shared/
so they're still duplicated between React and renderer packages.The actual file savings are negligible (a few dozen bytes after gzip for combined bundles). This is mostly to make it better from code organization perspective.
I tried putting them as a hidden export on the React object but this actually increased the size a bit because our secret export name is longer than the code this saves. 😛 Although maybe it would be nice to do in the future to fix cases like #8379 (comment). For now I decided not to do it.