Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure value and defaultValue do not assign functions and symbols #11741

Merged
merged 15 commits into from
Dec 4, 2017
Merged

Ensure value and defaultValue do not assign functions and symbols #11741

merged 15 commits into from
Dec 4, 2017

Commits on Dec 2, 2017

  1. Ensure value and defaultValue do not assign functions and symbols

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    e7ed5d6 View commit details
    Browse the repository at this point in the history

  2. Eliminate assignProperty method from ReactDOMInput

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    bf28fa3 View commit details
    Browse the repository at this point in the history

  3. Restore original placement of defaultValue reservedProp

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    5510b99 View commit details
    Browse the repository at this point in the history

  4. Reduce branching. Make assignment more consistent

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    570a1a1 View commit details
    Browse the repository at this point in the history

  5. Control for warnings in symbol/function tests

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    d99d97b View commit details
    Browse the repository at this point in the history

  6. Add boolean to readOnly assignments

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    ab9e932 View commit details
    Browse the repository at this point in the history

  7. Tweak the tests

    @gaearon @nhunzaker
    gaearon authored and nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    787cf4c View commit details
    Browse the repository at this point in the history

  8. Invalid value attributes should convert to an empty string

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    7215c8e View commit details
    Browse the repository at this point in the history

  9. Revert ChangeEventPlugin update. See #11746

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    80b5d92 View commit details
    Browse the repository at this point in the history

  10. Format

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    ec65674 View commit details
    Browse the repository at this point in the history

  11. Replace shouldSetAttribute call with value specific type check 

    DOMProperty.shouldSetAttribute runs a few other checks that aren't
appropriate for determining if a value or defaultValue should be
assigned on an input. This commit replaces that call with an input
specific check.
    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    a44c34f View commit details
    Browse the repository at this point in the history

  12. Remove unused import

    @nhunzaker
    nhunzaker committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    d843cfe View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2017

  1. Eliminate unnecessary numeric equality checks (#11751) 

    * Eliminate unnecessary numeric equality checks

This commit changes the way numeric equality for number inputs works
such that it compares against `input.valueAsNumber`. This eliminates
quite a bit of branching around numeric equality.

* There is no need to compare valueAsNumber

* Add test cases for empty string to 0.

* Avoid implicit boolean JSX props

* Split up numeric equality test to isolate eslint disable command

* Fix typo in ReactDOMInput test
    @nhunzaker @gaearon
    nhunzaker authored and gaearon committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    a65e25f View commit details
    Browse the repository at this point in the history

  2. Add todos

    @gaearon
    gaearon authored Dec 4, 2017
    Configuration menu
    Copy the full SHA
    ca66bd5 View commit details
    Browse the repository at this point in the history

  3. Update the attribute table

    @gaearon
    gaearon committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    343a334 View commit details
    Browse the repository at this point in the history