Sync scheduling by default, with an async opt-in #11771
Merged
+9
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
removesyncfeatureflag
branch
from
abe5a34
to
78c6976
Compare
sophiebits
reviewed
Dec 4, 2017
We could do that by branching here: Is that something you think we'll want, for debugging purposes? |
Removes the `useSyncScheduling` option from the HostConfig, since it's no longer needed. Instead of globally flipping between sync and async, our strategy will be to opt-in specific trees and subtrees.
acdlite
force-pushed
the
removesyncfeatureflag
branch
from
78c6976
to
f6fc30f
Compare
|
Maybe. Not a huge deal. |
ManasJayanth
pushed a commit
to ManasJayanth/react
that referenced
this pull request
Jan 12, 2018
Removes the `useSyncScheduling` option from the HostConfig, since it's no longer needed. Instead of globally flipping between sync and async, our strategy will be to opt-in specific trees and subtrees.
chentsulin
added a commit
to chentsulin/Making-a-custom-React-renderer
that referenced
this pull request
Jan 18, 2018
Removes the useSyncScheduling option from the HostConfig, since it's no longer needed. See facebook/react#11771
This was referenced Mar 30, 2018
This was referenced Mar 30, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Removes the `useSyncScheduling` option from the HostConfig, since it's no longer needed. Instead of globally flipping between sync and async, our strategy will be to opt-in specific trees and subtrees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
useSyncSchedulingoption from the HostConfig, since it's no longer needed. Instead of globally flipping between sync and async, our strategy will be to opt-in specific trees and subtrees.