Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test fixture for media event bubbling #12004

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

nhunzaker
Copy link
Contributor

We want to start refactoring some of the event constants, but we don't have a great way to confirm media events work as intended. This commit adds a new DOM test fixture to verify that media events bubble.

This should aid in testing #11912.

Also, I took a video of my dog as a test video. Hopefully this is okay :) I guess I abandon any rights to the video.

We want to start refactoring some of the event constants, but we don't
have a great way to confirm media events work as intended. This commit
adds a new DOM test fixture to verify that media events bubble.
@nhunzaker nhunzaker requested a review from gaearon January 11, 2018 00:33
@nhunzaker
Copy link
Contributor Author

Test page here:
http://nh-media-fixtures.surge.sh/media-events

@gaearon
Copy link
Collaborator

gaearon commented Jan 11, 2018

Also, I took a video of my dog as a test video. Hopefully this is okay :) I guess I abandon any rights to the video.

But what about patents

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good dog

@nhunzaker nhunzaker merged commit b422fec into facebook:master Jan 11, 2018
ManasJayanth pushed a commit to ManasJayanth/react that referenced this pull request Jan 12, 2018
We want to start refactoring some of the event constants, but we don't
have a great way to confirm media events work as intended. This commit
adds a new DOM test fixture to verify that media events bubble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants