Add media events back to TestUtils.Simulate #12010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestUtils lost media events when they were pulled out of the topLevelTypes constant. This commit adds them back by concatenating the media event keys to the list of top level types.
nhunzaker
commented
Jan 12, 2018
| const eventKeys = [].concat( | ||
| Object.keys(topLevelTypes), | ||
| Object.keys(mediaEventTypes), | ||
| ); |
There was a problem hiding this comment.
We could use EventPluginRegistry.eventNameDispatchConfigs for SimulateNative, but it:
- Does not include
invalid,mouseEnter,mouseLeave,reset,select, orsubmit. - Adds
selectionChange,textInput
Curiously, this is the case for ReactTestUtils.Simulate. Is this correct?
There was a problem hiding this comment.
Whatever’s currently there is “correct” in the sense that we shouldn’t change it now, and we should remove SimilateNative altogether in 17.
gaearon
approved these changes
Jan 12, 2018
ManasJayanth
pushed a commit
to ManasJayanth/react
that referenced
this pull request
Jan 12, 2018
The TestUtils lost media events when they were pulled out of the topLevelTypes constant. This commit adds them back by concatenating the media event keys to the list of top level types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestUtils lost media events when they were pulled out of the topLevelTypes constant. This commit adds them back by concatenating the media event keys to the list of top level types.
I tested this by recording a snapshot of the simulated events list on master before this commit. This will have to be updated every time we add a new event, but it should at least give us some extra.