Skip to content

Remove HTMLCanvasElement test mock #12020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Remove HTMLCanvasElement test mock #12020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions scripts/jest/setupEnvironment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,4 @@ if (typeof window !== 'undefined') {
event.preventDefault();
}
});

// Mock for ReactART.
HTMLCanvasElement.prototype.getContext = () => ({});
Copy link
Member Author

@rickhanlonii rickhanlonii Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon this was added in your commit here, do you happen to remember why it is necessary? I didn't see anything throwing without it

Copy link
Collaborator

@gaearon gaearon Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure ReactART-test failed without it

Copy link
Member Author

@rickhanlonii rickhanlonii Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed locally, let's see if it fails in CI

}