Update debugRenderPhaseSideEffects behavior #12057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bvaughn
requested review from
sebmarkbage,
gaearon,
acdlite and
flarnie
and removed request for
sebmarkbage
This feature flag no longer double-invokes componentWillMount, componentWillReceiveProps, componentWillUpdate, or shouldComponentUpdate. It continues to double-invoke the constructor, render, and setState updater functions as well as the recently added, static getDerivedStateFromProps method Tests have been updated.
|
Rebase~ |
flarnie
approved these changes
Jan 24, 2018
| // Instantiate twice to help detect side-effects. | ||
| if (debugRenderPhaseSideEffects) { | ||
| new ctor(props, context); // eslint-disable-line no-new | ||
| } |
There was a problem hiding this comment.
So this should call the constructor twice, right?
There was a problem hiding this comment.
Yes. It is called the second time right below:
const instance = new ctor(props, context);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of #12046
This
debugRenderPhaseSideEffectsfeature flag no longer double-invokescomponentWillMount,componentWillReceiveProps,componentWillUpdate, orshouldComponentUpdate.It continues to double-invoke the
constructor,render, andsetStateupdater functions as well as the recently added, staticgetDerivedStateFromPropsmethod.Tests have been updated.
I've verified that the
new ctorstatement inReactFiberClassComponentis not dropped from the production build.