-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add chinese translation support #1244
Conversation
Conflicts: docs/docs/01-why-react.zh-CN.md
This is awesome! I don't know the best way to present translated content, so I'll need to do a bit of work to expose this. So far the ideas in http://www.sp4ce.net/site/2011/01/15/how-to-have-a-multilingual-website-with-jekyll.html seem the most relevant (there are l10n plugins but focused around strings, not documents). A couple questions:
|
I'm new to this project, some words may not be accurate.I will fix these bugs later. Maybe you can also help me translate these doc better. |
In my spare time, I will translate more docs these days. Maybe it need a system to notify me when the documents changes.Can Github's hooks do that? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I'm going to merge these in so we at least have them, then we can figure out how to manage these later. Sorry for the delay, this just hasn't been a huge priority for us yet. |
Is there still a plan to translate docs into Chinese? |
@jiyinyiyong My concern is that we don't have a process for making sure translations stay up to date. I would be interested in having more translated content but since it's so easy to fall out of sync, I don't want to get stuck in a situation where we're spreading misinformation or outdated information to a group of people. |
@zpao I want to try this one here: https://github.com/react-china/react-docs Maybe I should lock down a version here. |
The website/docs are generated by Jekyll (for now) from the Some things not mentioned there:
|
@zpao Really thanks, will look into it. |
I put the translation file in the
docs/docs/01-why-react.zh-CN.md
.Should i put the translation file into another folder or not?
So make it easy, i make the translation file's name end with zh-CN.