Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for unstable_renderSubtreeIntoContainer #12730

Closed
wants to merge 1 commit into from
Closed

Add deprecation warning for unstable_renderSubtreeIntoContainer #12730

wants to merge 1 commit into from

Conversation

raunofreiberg
Copy link
Contributor

PR to kick off the issue over at #10143.

When should the API itself be removed? I currently specified the 17+ version in the deprecation warning, although I'm not sure if that is in alignment with the actual plan.

@pull-bot
Copy link

pull-bot commented May 2, 2018

Details of bundled changes.

Comparing: ad7cd68...39837f0

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% 0.0% 611.8 KB 612.15 KB 141.4 KB 141.43 KB UMD_DEV
react-dom.development.js +0.1% 0.0% 596.18 KB 596.53 KB 137.23 KB 137.26 KB NODE_DEV
ReactDOM-dev.js +0.1% 0.0% 620.62 KB 621 KB 139.99 KB 140.03 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 284.19 KB 284.53 KB 51.94 KB 51.98 KB FB_WWW_PROD

Generated by 🚫 dangerJS

@stale
Copy link

stale bot commented Jan 10, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 17, 2020

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants