Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use empty value in input button #12887

Closed

Conversation

gebilaoxiong
Copy link
Contributor

Close: #12872

@pull-bot
Copy link

pull-bot commented May 23, 2018

ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.1%

Details of bundled changes.

Comparing: c601f7a...15cf3c3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 621.4 KB 621.79 KB 144.74 KB 144.81 KB UMD_DEV
react-dom.production.min.js 🔺+0.2% 🔺+0.1% 93.69 KB 93.88 KB 30.33 KB 30.37 KB UMD_PROD
react-dom.development.js +0.1% 0.0% 605.76 KB 606.15 KB 140.74 KB 140.8 KB NODE_DEV
react-dom.production.min.js 🔺+0.2% 🔺+0.2% 92.19 KB 92.38 KB 29.31 KB 29.35 KB NODE_PROD
ReactDOM-dev.js +0.1% 0.0% 628.05 KB 628.46 KB 143.5 KB 143.56 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.2% 273.68 KB 274.06 KB 51.53 KB 51.61 KB FB_WWW_PROD

Generated by 🚫 dangerJS

@gebilaoxiong gebilaoxiong changed the title allow empty value in submit & reset button allow use empty value in input button May 23, 2018
@aweary
Copy link
Contributor

aweary commented May 23, 2018

Thanks, but there's already an open pull request for this #12780

@aweary aweary closed this May 23, 2018
@gebilaoxiong
Copy link
Contributor Author

gebilaoxiong commented May 23, 2018

@aweary Yes, I noticed it. But I think there's something wrong with that pr.

Twelve days have passed.

I thinkI can keep close with this question, thx?

@ellsclytn
Copy link
Contributor

ellsclytn commented May 24, 2018

I'll get back to #12780 within the next couple of days 🙂. It's been open for a while because I didn't open an Issue with it at first, so it went unnoticed for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants