Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodejs 10 to windows test #13241

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

gengjiawen
Copy link
Contributor

No description provided.

@gaearon
Copy link
Collaborator

gaearon commented Aug 1, 2018

Let's just use 10? We don't want Windows CI to be slow, and in general we mainly support development on latest versions.

@gengjiawen
Copy link
Contributor Author

@gaearon done.

@gaearon
Copy link
Collaborator

gaearon commented Aug 1, 2018

Forgot to push?

@gengjiawen
Copy link
Contributor Author

pushed to the wrong branch, sorry :)

@gaearon gaearon merged commit d79238f into facebook:master Aug 2, 2018
@gaearon
Copy link
Collaborator

gaearon commented Aug 2, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants