Run tests for Fire feature flags #13628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: d3bbfe0...c2d6dda schedule
Generated by 🚫 dangerJS |
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
* Run tests for Fire feature flags * Only run ReactDOM tests for Fire
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Run tests for Fire feature flags * Only run ReactDOM tests for Fire
philipp-spiess
added a commit
to philipp-spiess/reactjs.org
that referenced
this pull request
Jan 23, 2019
facebook/react#13628 added React Fire specific test scripts. This note should help contributors test against the Fire fork as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I just thought we'd fork a few test files, but I'm worried now that we'll accidentally break some tests we don't normally run. It's pretty simple to run with feature flags on so I'm adding
yarn test-fireandyarn test-fire-prodthat does that.There are no actual feature flags yet. #13526 will be the first one.