-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename schedule to scheduler #13683
Rename schedule to scheduler #13683
Conversation
@@ -38,12 +38,12 @@ if (__UMD__) { | |||
// This re-export is only required for UMD bundles; | |||
// CJS bundles use the shared NPM package. | |||
Object.assign(ReactSharedInternals, { | |||
Schedule: { | |||
Scheduler: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this means a newer React wouldn't work with an older ReactDOM, or vice versa. Since it's scoped to UMDs only I think that's fine and I wouldn't worry about going to extra lengths to make this work for mismatching versions.
Details of bundled changes.Comparing: 9b70816...f7973b1 scheduler
Generated by 🚫 dangerJS |
Can I ask why we use 'schedule' rather than 'scheduler' when we rename it before? IIRC, we use 'react-scheduler' before but rename it to 'schedule', sorry about don‘t come up with this confusion in that PR |
We didn't own the |
Perhaps a silly question but couldn't easily find answers to this, but has |
We have talked a little about potentially using |
I think it will break the webpack config when we use the schedule ==> scheduler Beforemodule.exports = {
//...
resolve: {
alias: {
'react-dom': 'react-dom/profiling',
'schedule/tracing': 'schedule/tracing-profiling',
}
}
}; Aftermodule.exports = {
//...
resolve: {
alias: {
'react-dom': 'react-dom/profiling',
'scheduler/tracing': 'scheduler/tracing-profiling',
}
}
}; |
Yeah, we need to change these instructions. |
Here ? |
Both fb.me/react-profiling and fb.me/react-interaction-tracing have been udpated! |
Ran the fixtures and I think everything works.