Centralize props memoization #13900
Merged
Centralize props memoization #13900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always call this at the end. This is now enforced to line up since we do the equality check in the beginning of beginWork. So we can't have special cases.
sebmarkbage
commented
Oct 20, 2018
| @@ -314,7 +311,6 @@ function updateMode( | |||
| nextChildren, | |||
| renderExpirationTime, | |||
| ); | |||
| memoizeProps(workInProgress, nextChildren); | |||
There was a problem hiding this comment.
This one is interesting because it doesn't memoize its props. Only its children. This is a bug since it won't bail out ever.
|
ReactDOM: size: -0.4%, gzip: -0.3% Details of bundled changes.Comparing: fa65c58...15930b9 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
acdlite
approved these changes
Oct 20, 2018
linjiajian999
pushed a commit
to linjiajian999/react
that referenced
this pull request
Oct 22, 2018
* Move memoizedProps to after beginWork remove memoizeProps helper We always call this at the end. This is now enforced to line up since we do the equality check in the beginning of beginWork. So we can't have special cases. * Inline the one caller of memoizeState
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Move memoizedProps to after beginWork remove memoizeProps helper We always call this at the end. This is now enforced to line up since we do the equality check in the beginning of beginWork. So we can't have special cases. * Inline the one caller of memoizeState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compare pendingProps against memoizedProps in beginWork so we already have strong assumptions that can't vary by branch. So we can simplify this which lets us get rid of the special case in lazy.