Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfork Lazy Component Branches #13902

Merged
merged 7 commits into from
Oct 20, 2018
Merged

Unfork Lazy Component Branches #13902

merged 7 commits into from
Oct 20, 2018

Commits on Oct 20, 2018

  1. Introduce elementType field 

    This will be used to store the wrapped type of an element. E.g. pure and
lazy.

The existing type field will be used for the unwrapped type within them.
    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    aedc6ba View commit details
    Browse the repository at this point in the history

  2. Store the unwrapped type on the type field of lazy components

    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    4949da9 View commit details
    Browse the repository at this point in the history

  3. Use the raw tags for lazy components 

    Instead, we check if the elementType and type are equal to test if
we need to resolve props. This is slightly slower in the normal case
but will yield less code and branching.
    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    2e07411 View commit details
    Browse the repository at this point in the history

  4. Clean up lazy branches

    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    0f75e25 View commit details
    Browse the repository at this point in the history

  5. Collapse work tag numbering

    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    e6b9e26 View commit details
    Browse the repository at this point in the history

  6. Split IndeterminateComponent out from Lazy 

    This way we don't have to check the type in a hacky way in the
indeterminate path. Also, lets us deal with lazy that resolves to
indeterminate and such.
    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    6a70389 View commit details
    Browse the repository at this point in the history

  7. Missing clean up in rebase

    @sebmarkbage
    sebmarkbage committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    b2ee274 View commit details
    Browse the repository at this point in the history