-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unstable_ prefix from Suspense #13922
Conversation
We are using it with lazy and the combination Suspense + lazy seems pretty stable. maxDuration is not but that's only enabled when you're in ConcurrentMode which is still unstable.
Although I guess #13921 is a counter argument. :) |
Would be nice to follow up to understand how it landed while breaking that test. |
Should maxDuration be prefixed? |
I think it's fine to leave |
Details of bundled changes.Comparing: 04c4f2f...7d66f90 scheduler
Generated by 🚫 dangerJS |
We are using it with lazy and the combination Suspense + lazy seems pretty stable. maxDuration is not but that's only enabled when you're in ConcurrentMode which is still unstable.
We are using it with lazy and the combination Suspense + lazy seems pretty stable. maxDuration is not but that's only enabled when you're in ConcurrentMode which is still unstable.
Don't forget to fix www.