Udpate readme.md / Grammar fix (comma mistake) #13924
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deleted the comma in the sentence:
"JSX is not required to use React, but it makes code more readable, and writing it feels like writing HTML."
When the sentence only contains two listed items, they should not be separated by a comma before using "and".
You should not use a comma before and if you’re only mentioning two qualities.
The dog is well trained and good natured. - V Right way to use
The dog is well trained, and good natured. - X Wrong way to use
See: https://www.grammarly.com/blog/comma-before-and/
Hence:
...it makes code more readable and writing it feels like writing HTML. - V
...it makes code more readable, and writing it feels like writing HTML. -X
Cheers :) Keep up the amazing work!
Before submitting a pull request, please make sure the following is done:
master
.yarn
in the repository root.yarn test
). Tip:yarn test --watch TestName
is helpful in development.yarn test-prod
to test in the production environment. It supports the same options asyarn test
.yarn debug-test --watch TestName
, openchrome://inspect
, and press "Inspect".yarn prettier
).yarn lint
). Tip:yarn linc
to only check changed files.yarn flow
).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html