Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable stable concurrent APIs flag for 16.7 alpha #13928

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Enable stable concurrent APIs flag for 16.7 alpha #13928

merged 2 commits into from
Oct 24, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Oct 23, 2018

These APIs will no longer be "unstable" in the upcoming 16.7 release. Rename them behind a feature flag though, in case we need to publish a 16.6 minor release in the meanwhile.

@sebmarkbage
Copy link
Collaborator

Let's land this after 16.6 is out.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 23, 2018

Yes of course. 😄 Just getting it ready.

@klamping klamping mentioned this pull request Oct 23, 2018
Open
@sizebot
Copy link

sizebot commented Oct 23, 2018

React: size: 0.0%, gzip: 🔺+0.1%

Details of bundled changes.

Comparing: 508b5fb...edb032e

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.4% +0.4% 93.7 KB 94.05 KB 24.67 KB 24.77 KB UMD_DEV
react.production.min.js 0.0% 🔺+0.1% 11.67 KB 11.67 KB 4.61 KB 4.62 KB UMD_PROD
react.development.js +2.0% +3.0% 56.41 KB 57.56 KB 15.19 KB 15.64 KB NODE_DEV
react.production.min.js 🔺+0.1% 🔺+0.2% 6.08 KB 6.09 KB 2.59 KB 2.6 KB NODE_PROD
React-dev.js +1.5% +1.6% 52.75 KB 53.54 KB 14.33 KB 14.56 KB FB_WWW_DEV
React-prod.js -1.3% 🔺+0.3% 13.93 KB 13.75 KB 3.81 KB 3.82 KB FB_WWW_PROD
React-profiling.js -1.3% +0.3% 13.93 KB 13.75 KB 3.81 KB 3.82 KB FB_WWW_PROFILING
react.profiling.min.js 0.0% +0.1% 13.82 KB 13.83 KB 5.13 KB 5.14 KB UMD_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% +0.1% 681.15 KB 681.44 KB 158.13 KB 158.23 KB UMD_DEV
react-dom.development.js 0.0% +0.1% 676.49 KB 676.78 KB 156.74 KB 156.84 KB NODE_DEV
react-dom-server.browser.development.js +0.1% +0.3% 108.22 KB 108.38 KB 28.61 KB 28.69 KB UMD_DEV
react-dom-server.browser.development.js +0.2% +0.3% 104.36 KB 104.51 KB 27.62 KB 27.7 KB NODE_DEV
react-dom-server.node.development.js +0.1% +0.3% 106.28 KB 106.43 KB 28.17 KB 28.25 KB NODE_DEV
ReactDOM-dev.js 0.0% 0.0% 694.88 KB 695.02 KB 157.44 KB 157.48 KB FB_WWW_DEV

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD
scheduler-tracing.development.js +1.6% +3.3% 10.08 KB 10.24 KB 2.28 KB 2.35 KB NODE_DEV

Generated by 🚫 dangerJS

@bvaughn bvaughn changed the title Enable stable concurrent mode ap is Enable stable concurrent APIs flag for 16.7 alpha Oct 23, 2018
@bvaughn bvaughn requested review from gaearon, sebmarkbage and sophiebits and removed request for sophiebits, sebmarkbage and gaearon October 24, 2018 15:05
@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 24, 2018

Ready to go now I guess 😄

@bvaughn bvaughn merged commit 275e76e into facebook:master Oct 24, 2018
@bvaughn bvaughn deleted the enableStableConcurrentModeAPIs branch October 24, 2018 20:45
@raunofreiberg raunofreiberg mentioned this pull request Oct 29, 2018
Merged
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@bvaughn @jetoneza
Enable stable concurrent APIs flag for 16.7 alpha (facebook#13928)
194fe38 
* Add enableStableConcurrentModeAPIs feature flag

* Conditionally name concurrent API based on enableStableConcurrentModeAPIs flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@gaearon gaearon Awaiting requested review from gaearon

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@sophiebits sophiebits Awaiting requested review from sophiebits

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bvaughn @sebmarkbage @sizebot @acdlite @facebook-github-bot