Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed react-cache from the bundle list for now #13930

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Removed react-cache from the bundle list for now #13930

merged 2 commits into from
Oct 23, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Oct 23, 2018 •
edited
Loading

We don't want to release this with 16.6

sebmarkbage
sebmarkbage approved these changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this passes CI.

@klamping klamping mentioned this pull request Oct 23, 2018
Open
@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 23, 2018 •
edited
Loading

Meh, I think private: true in JSON is nicer so I'm going to push an update.

@bvaughn bvaughn merged commit 80a0c05 into facebook:master Oct 23, 2018
@bvaughn bvaughn deleted the temporarily-remove-react-cache-bundle branch October 23, 2018 20:55
@sizebot
Copy link

sizebot commented Oct 23, 2018

Details of bundled changes.

Comparing: 508b5fb...d62b353

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@bvaughn @jetoneza
Removed react-cache from the bundle list for now (facebook#13930)
36f8152 
* Removed react-cache from the bundle list for now

* Re-add react-cache bundle, but mark as private to avoid NPM publishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvaughn @sizebot @sebmarkbage @facebook-github-bot