Update the benchmark script (upgrade lighthouse to v3) #13994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to run some benchmark tests but I couldn't get the current script to work (lighthouse threw an obscure error of
Cannot read property 'args' of undefined
). I debugged it for a bit but didn't have much luck.So I tried to upgrade
lighthouse
to v3 and it seems to work fine. Here's a fullyarn start
run -- does the output seem reasonable?