Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCE hooks code when flag is off #14111

Merged
merged 1 commit into from
Nov 5, 2018
Merged

DCE hooks code when flag is off #14111

merged 1 commit into from
Nov 5, 2018

Conversation

sophiebits
Copy link
Collaborator

I think this will work. Let's check sizebot.

@sophiebits sophiebits requested review from gaearon and acdlite November 5, 2018 19:17
@sophiebits sophiebits force-pushed the dce-hooks branch 2 times, most recently from ddbf8fd to 846bd19 Compare November 5, 2018 19:20
@sizebot
Copy link

sizebot commented Nov 5, 2018 •
edited
Loading

ReactDOM: size: -4.6%, gzip: -4.9%

Details of bundled changes.

Comparing: 8eca0ef...e59c3a6

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% 0.0% 704.43 KB 704.81 KB 163.21 KB 163.28 KB UMD_DEV
react-dom.production.min.js -4.6% -4.9% 102.58 KB 97.9 KB 33.56 KB 31.91 KB UMD_PROD
react-dom.development.js +0.1% 0.0% 699.74 KB 700.12 KB 161.83 KB 161.9 KB NODE_DEV
react-dom.production.min.js -4.6% -5.0% 102.67 KB 97.92 KB 33.1 KB 31.46 KB NODE_PROD
react-dom-server.browser.development.js +0.2% +0.1% 118.4 KB 118.59 KB 31.35 KB 31.38 KB UMD_DEV
react-dom-server.browser.production.min.js -9.0% -9.3% 17.58 KB 16 KB 6.71 KB 6.08 KB UMD_PROD
react-dom-server.browser.development.js +0.2% +0.1% 114.53 KB 114.72 KB 30.39 KB 30.42 KB NODE_DEV
react-dom-server.browser.production.min.js -9.0% -9.2% 17.48 KB 15.9 KB 6.7 KB 6.08 KB NODE_PROD
react-dom-server.node.development.js +0.2% +0.1% 116.45 KB 116.64 KB 30.93 KB 30.96 KB NODE_DEV
react-dom-server.node.production.min.js -8.6% -8.8% 18.28 KB 16.7 KB 7 KB 6.38 KB NODE_PROD
ReactDOM-dev.js +0.1% +0.1% 718.22 KB 718.61 KB 162.68 KB 162.77 KB FB_WWW_DEV
ReactDOM-prod.js -4.8% -5.2% 310.49 KB 295.67 KB 57.37 KB 54.41 KB FB_WWW_PROD
ReactDOMServer-dev.js +0.2% +0.1% 114.63 KB 114.82 KB 29.87 KB 29.91 KB FB_WWW_DEV
ReactDOMServer-prod.js -12.5% -11.1% 40.58 KB 35.52 KB 9.57 KB 8.51 KB FB_WWW_PROD
react-dom.profiling.min.js -4.2% -4.4% 105.04 KB 100.64 KB 33.41 KB 31.96 KB NODE_PROFILING
ReactDOM-profiling.js -4.8% -4.9% 314.75 KB 299.78 KB 58.25 KB 55.39 KB FB_WWW_PROFILING
react-dom.profiling.min.js -4.2% -4.2% 104.91 KB 100.55 KB 33.9 KB 32.48 KB UMD_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 491.55 KB 491.92 KB 108.95 KB 109.03 KB UMD_DEV
react-art.production.min.js -4.6% -5.1% 94.46 KB 90.11 KB 29.16 KB 27.69 KB UMD_PROD
react-art.development.js +0.1% +0.1% 423.34 KB 423.71 KB 91.92 KB 92 KB NODE_DEV
react-art.production.min.js -7.4% -8.1% 59.5 KB 55.12 KB 18.49 KB 16.99 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 428.16 KB 428.55 KB 90.48 KB 90.57 KB FB_WWW_DEV
ReactART-prod.js -8.0% -9.3% 183.64 KB 168.92 KB 31.51 KB 28.59 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 435.98 KB 436.36 KB 94.59 KB 94.67 KB UMD_DEV
react-test-renderer.production.min.js -7.2% -8.1% 60.69 KB 56.31 KB 18.87 KB 17.35 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 431.2 KB 431.57 KB 93.44 KB 93.53 KB NODE_DEV
react-test-renderer.production.min.js -7.3% -8.0% 60.38 KB 55.99 KB 18.64 KB 17.15 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 436.2 KB 436.59 KB 92.34 KB 92.43 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 421.18 KB 421.56 KB 90.35 KB 90.44 KB NODE_DEV
react-reconciler.production.min.js -7.2% -7.7% 60.72 KB 56.32 KB 18.28 KB 16.87 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.1% 419.63 KB 420.01 KB 89.73 KB 89.82 KB NODE_DEV
react-reconciler-persistent.production.min.js -7.2% -7.7% 60.73 KB 56.33 KB 18.29 KB 16.87 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 554.44 KB 554.81 KB 121.35 KB 121.43 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.2% 🔺+0.1% 238.53 KB 238.14 KB 42.02 KB 42.08 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% +0.1% 554.11 KB 554.5 KB 121.25 KB 121.34 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -6.3% -7.2% 238.55 KB 223.6 KB 42.02 KB 38.99 KB RN_OSS_PROD
ReactFabric-dev.js +0.1% +0.1% 544.63 KB 545.02 KB 118.86 KB 118.95 KB RN_FB_DEV
ReactFabric-prod.js -6.4% -7.4% 233.42 KB 218.39 KB 40.72 KB 37.69 KB RN_FB_PROD
ReactFabric-dev.js +0.1% +0.1% 544.66 KB 545.05 KB 118.88 KB 118.96 KB RN_OSS_DEV
ReactFabric-prod.js -6.4% -7.4% 233.45 KB 218.42 KB 40.74 KB 37.71 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -6.2% -6.9% 244.24 KB 229.03 KB 43.23 KB 40.26 KB RN_OSS_PROFILING
ReactFabric-profiling.js -6.4% -7.2% 237.99 KB 222.74 KB 41.99 KB 38.95 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js -0.2% +0.1% 244.22 KB 243.83 KB 43.23 KB 43.28 KB RN_FB_PROFILING
ReactFabric-profiling.js -6.4% -7.2% 237.95 KB 222.7 KB 41.97 KB 38.93 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

gaearon
gaearon approved these changes Nov 5, 2018
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably more things you can DCE in CommitWork but I love how low-effort this is.

@sophiebits sophiebits merged commit ebdb47d into facebook:master Nov 5, 2018
@acdlite acdlite mentioned this pull request Nov 6, 2018
Merged
gaearon pushed a commit to gaearon/react that referenced this pull request Nov 6, 2018
@sophiebits @gaearon
DCE hooks code when flag is off (facebook#14111)
a86848f
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@sophiebits @jetoneza
DCE hooks code when flag is off (facebook#14111)
863541e
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@sophiebits @n8schloss
DCE hooks code when flag is off (facebook#14111)
76b6579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophiebits @sizebot @gaearon @facebook-github-bot