Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synchronous Suspense] Reuse deletions from primary tree #14133

Merged
merged 1 commit into from
Nov 7, 2018
Merged

[Synchronous Suspense] Reuse deletions from primary tree #14133

merged 1 commit into from
Nov 7, 2018

Commits on Nov 7, 2018

  1. [Synchronous Suspense] Reuse deletions from primary tree 

    Fixes a bug where deletion effects in the primary tree were dropped
before entering the second render pass.

Because we no longer reset the effect list after the first render pass,
I've also moved the deletion of the fallback children to the complete
phase, after the tree successfully renders without suspending.

Will need to revisit this heuristic when we implement resuming.
    @acdlite
    acdlite committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    7788bee View commit details
    Browse the repository at this point in the history