Remove useMutationEffect #14336
Merged
Remove useMutationEffect #14336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Nov 27, 2018
|
sorry @kentcdodds |
|
Haha, I'll update my blogpost :D |
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 48f1e5b...708c60a react-dom
Generated by 🚫 dangerJS |
useMutationEffect has problems (namely, refs aren't attached at the time that it runs) and we're not positive it's necessary. useLayoutEffect runs at the same time as componentDidMount/Update so it's sufficient for all existing use cases; it can be used in any case that useEffect happens too late. Until we figure out what we want to do, let's delete it.
sophiebits
added a commit
to sophiebits/react.dev
that referenced
this pull request
Nov 27, 2018
4 tasks
diegohaz
added a commit
to diegohaz/constate
that referenced
this pull request
Nov 28, 2018
BREAKING CHANGE: `useContextMutationEffect` has been removed. `React.useMutationEffect` will be removed from React hooks, so this is just to reflect that (see facebook/react#14336).
sophiebits
added a commit
to reactjs/react.dev
that referenced
this pull request
Nov 28, 2018
|
Maybe we can also update docs here. Code snippet explaining how to read an often-changing value from useCallback used this hook which is no longer available. |
|
That exact link has already been updated. |
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Nov 29, 2018
Summary: Resolves #7219 - [x] 2fdcda5: Removed `React.useMutationEffect` hook (facebook/react/pull/14336) and updated tests. This hook was only ever exposed in an alpha release of 16.7 and so it should be safe to remove in a non-backwards-compatible way. - [x] dabf49e: Add `React.Suspense` component and tests. (No final public documentation exists for `Suspense` yet– although we're working on it. For the time being, [tests like this](https://github.com/facebook/react/blob/master/packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js) can serve as a reference.) - [x] 8df05bd: Fixed invalid `useCallback` definition and tests. - [x] 063b022: Fixed invalid `React.lazy` signature to reflect that a `Promise` with a "default" property should be returned (rather than a React component). Pull Request resolved: #7213 Reviewed By: jbrown215 Differential Revision: D13222880 Pulled By: bvaughn fbshipit-source-id: 77e59e320698567c343c91a67b3aa91e9c925873
Jessidhia
added a commit
to Jessidhia/DefinitelyTyped
that referenced
this pull request
Dec 3, 2018
Jessidhia
added a commit
to Jessidhia/DefinitelyTyped
that referenced
this pull request
Dec 3, 2018
6 tasks
johnnyreilly
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Dec 3, 2018
gabelevi
pushed a commit
to facebook/flow
that referenced
this pull request
Dec 4, 2018
Summary: Resolves #7219 - [x] 2fdcda5: Removed `React.useMutationEffect` hook (facebook/react/pull/14336) and updated tests. This hook was only ever exposed in an alpha release of 16.7 and so it should be safe to remove in a non-backwards-compatible way. - [x] dabf49e: Add `React.Suspense` component and tests. (No final public documentation exists for `Suspense` yet– although we're working on it. For the time being, [tests like this](https://github.com/facebook/react/blob/master/packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js) can serve as a reference.) - [x] 8df05bd: Fixed invalid `useCallback` definition and tests. - [x] 063b022: Fixed invalid `React.lazy` signature to reflect that a `Promise` with a "default" property should be returned (rather than a React component). Pull Request resolved: #7213 Reviewed By: jbrown215 Differential Revision: D13222880 Pulled By: bvaughn fbshipit-source-id: 9e1b48ace984051928c4ab92fa61182ad70f7119
yuchi
added a commit
to yuchi/hooks.macro
that referenced
this pull request
Dec 18, 2018
Also, I was **not** testing for them, so... Related: facebook/react#14336
Someone asked the above question (but I guess it was deleted before I had a chance to respond?) Anyway, in case someone else comes across this PR and wonders the same– it seemed worth re-emphasizing what Sophie said in the PR description:
Updating the above repro to use |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
useMutationEffect has problems (namely, refs aren't attached at the time that it runs) and we're not positive it's necessary. useLayoutEffect runs at the same time as componentDidMount/Update so it's sufficient for all existing use cases; it can be used in any case that useEffect happens too late. Until we figure out what we want to do, let's delete it.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
useMutationEffect has problems (namely, refs aren't attached at the time that it runs) and we're not positive it's necessary. useLayoutEffect runs at the same time as componentDidMount/Update so it's sufficient for all existing use cases; it can be used in any case that useEffect happens too late. Until we figure out what we want to do, let's delete it.
yesmeck
added a commit
to yesmeck/react-with-hooks
that referenced
this pull request
Feb 3, 2019
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMutationEffect has problems (namely, refs aren't attached at the time that it runs) and we're not positive it's necessary. useLayoutEffect runs at the same time as componentDidMount/Update so it's sufficient for all existing use cases; it can be used in any case that useEffect happens too late. Until we figure out what we want to do, let's delete it.