Release script auto-determine the latest Canary build if none specified #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
reviewed
Nov 27, 2018
| // https://circleci.com/docs/api/#recent-builds-for-a-project-branch | ||
| const metadataURL = `https://circleci.com/api/v1.1/project/github/facebook/react/tree/master`; | ||
| const metadata = await http.get(metadataURL, true); | ||
| const build = metadata.find(entry => entry.branch === 'master').build_num; |
There was a problem hiding this comment.
Do you want the latest completed+successful build instead of just the latest? Failed and incomplete both seem subpar.
There was a problem hiding this comment.
🤔 Good point. (done)
|
🕺 If anyone disagrees with this change I'll revert it. |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…ed (facebook#14339) * Release script auto-determine the latest Canary build if none specified
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…ed (facebook#14339) * Release script auto-determine the latest Canary build if none specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this would be useful if we want to integrate with the FB sync script. Also it's just convenient.
Now you can prepare a specified build:
Or just prepare the most recent one from
master:Demo