Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid importing Scheduler directly #14757

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Avoid importing Scheduler directly #14757

merged 2 commits into from
Feb 5, 2019

Commits on Feb 5, 2019

  1. Avoid importing Scheduler directly 

    The reconciler should not depend directly on Scheduler. This adds it to
the host config for the renderer instead.

(Except for `scheduler/tracing` imports, which are used only by the
profiling build. I've left those imports as-is, though I'm open to
directing those through the host config, too.)
    @acdlite
    acdlite committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    6ebe54e View commit details
    Browse the repository at this point in the history

  2. Make throwaway root id longer to appease Brian

    @acdlite
    acdlite committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    e0ea64b View commit details
    Browse the repository at this point in the history