Use the canonical nativeTag for Fabric's setNativeProps #14900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to run |
sebmarkbage
approved these changes
Feb 20, 2019
|
Beat you to it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to be working on migrating the API for setNativeProps and wanted to add a better assertion for the current setNativeProps behavior. I found that with the Fabric renderer the first argument to setNativeProps was
undefined.I'm pretty sure we will be changing this later as Fabric won't be calling
UIManager.updateViewat all but this can at least be changed for now.Related to react-native-community/discussions-and-proposals#72