Adding setNativeProps tests for NativeMethodsMixin #14901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
commented
Feb 20, 2019
| @@ -30,8 +32,16 @@ describe('ReactFabric', () => { | |||
| ReactFabric = require('react-native-renderer/fabric'); | |||
| FabricUIManager = require('FabricUIManager'); | |||
| UIManager = require('UIManager'); | |||
| createReactClass = require('create-react-class/factory')( | |||
There was a problem hiding this comment.
I copied this from
sebmarkbage
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to add a warning for setNativeProps on NativeMethodsMixin so I'm adding a test for the current behavior to be able to check for the warning in a follow up.
I'm also adding a test for the Fabric renderer which required for checking
canonical. This isn't super relevant because NativeMethodsMixin won't work for Fabric at all, but this will probably help during the migration.Related to react-native-community/discussions-and-proposals#72