Fix UMD builds by re-exporting the scheduler priorities #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Feb 21, 2019
| unstable_ImmediatePriority, | ||
| unstable_LowPriority, | ||
| unstable_NormalPriority, | ||
| unstable_UserBlockingPriority, |
There was a problem hiding this comment.
This is the important part of the fix. The rest isn't.
threepointone
approved these changes
Feb 21, 2019
|
I built a version of the fixtures with this change: Looks good to me, 👍 |
gaearon
added a commit
to acdlite/react
that referenced
this pull request
Feb 21, 2019
Deraen
added a commit
to cljsjs/packages
that referenced
this pull request
Mar 2, 2019
## 16.8.2 => 16.8.3 ### React DOM * Fix a bug that caused inputs to behave incorrectly in UMD builds. ([@gaearon](https://github.com/gaearon) in [#14914](facebook/react#14914)) * Fix a bug that caused render phase updates to be discarded. ([@gaearon](https://github.com/gaearon) in [#14852](facebook/react#14852)) ### React DOM Server * Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. ([@overlookmotel](https://github.com/overlookmotel) in [#14706](facebook/react#14706))
Deraen
added a commit
to cljsjs/packages
that referenced
this pull request
Mar 2, 2019
## 16.8.2 => 16.8.3 ### React DOM * Fix a bug that caused inputs to behave incorrectly in UMD builds. ([@gaearon](https://github.com/gaearon) in [#14914](facebook/react#14914)) * Fix a bug that caused render phase updates to be discarded. ([@gaearon](https://github.com/gaearon) in [#14852](facebook/react#14852)) ### React DOM Server * Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. ([@overlookmotel](https://github.com/overlookmotel) in [#14706](facebook/react#14706))
This was referenced Mar 2, 2019
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Sep 22, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This was referenced Sep 30, 2019
Open
This was referenced Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14904.
Fixes the regression to UMD builds since #14756 which caused all interactive updates in 16.8.2 to be scheduled with low priority.
We had a test that checked for those but it used to ignore priorities because it wasn't important at the time. I'm making the test check those too.
Since the existing test also verifies the Scheduler UMD bundles, I added getters to those to make sure the API matches up. But that's not the important part of this fix. The important part is just adding those constants to "scheduler internals" for UMD.
Note this means that even ReactDOM 16.8.3+ won't work correctly with older React UMDs. This might be surprising but it breaks often enough for UMDs that it's probably okay.