Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incompatibility between react-debug-tools and useContext() #14940

Merged
merged 5 commits into from
Feb 26, 2019
Merged

Fixed incompatibility between react-debug-tools and useContext() #14940

merged 5 commits into from
Feb 26, 2019
+600 −171

Commits on Feb 26, 2019

  1. ReactDebugHooks useContext() advances hooks list in DEV mode

    Brian Vaughn committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    1975f38 View commit details
    Browse the repository at this point in the history

  2. Don't bypass useContext to go straight to readContext anymore 

    This adds a small amount of overhead, so I'm not sure if it will fly. I think it might be necessary though in order to support the react-debug-tools package.
    Brian Vaughn committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    842d135 View commit details
    Browse the repository at this point in the history

  3. Refactor hook ordering check to use DEV-only data structure 

    This enables us to warn about more cases (e.g. useContext, useDebugValue) withou the need to add any overhead to production bundles.
    Brian Vaughn committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    9bbd4f4 View commit details
    Browse the repository at this point in the history

  4. DEV mode hook mount/update check uses same logic as prod

    Brian Vaughn committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    c2fc659 View commit details
    Browse the repository at this point in the history

  5. Added separate dispatcher for DEV-mode hooks update with no stateful … 

    …hooks
    Brian Vaughn committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    3899681 View commit details
    Browse the repository at this point in the history