Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace noop's fake Scheduler implementation with mock Scheduler build #14969

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Replace noop's fake Scheduler implementation with mock Scheduler build #14969

merged 2 commits into from
Feb 28, 2019

Commits on Feb 27, 2019

  1. Replace noop's fake Scheduler implementation with mock Scheduler build 

    The noop renderer has its own mock implementation of the Scheduler
interface, with the ability to partially render work in tests. Now that
this functionality has been lifted into a proper mock Scheduler build,
we can use that instead.

Most of the existing noop tests were unaffected, but I did have to make
some changes. The biggest one involved passive effects: previously, they
were scheduled on a separate queue from the queue that handles
rendering. After this change, both rendering and effects are scheduled
in the Scheduler queue. I think this is a better approach because tests
no longer have to worry about the difference; if you call `flushAll`,
all the work is flushed, both rendering and effects. But for those few
tests that do care to flush the rendering without the effects, that's
still possible using the `yieldValue` API.

Follow-up: Do the same for test renderer.
    @acdlite
    acdlite committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    a9fad18 View commit details
    Browse the repository at this point in the history

  2. Fix import to scheduler/unstable_mock

    @acdlite
    acdlite committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    932034c View commit details
    Browse the repository at this point in the history