[Outdated; needs revision] Add support for normal errors to error code infra

.eslintrc.js

@@ -89,6 +89,7 @@ module.exports = {
     'react-internal/no-primitive-constructors': ERROR,
     'react-internal/no-to-warn-dev-within-to-throw': ERROR,
     'react-internal/warning-and-invariant-args': ERROR,
+    'react-internal/static-error-messages': ERROR,
   },
 
   overrides: [
@@ -124,8 +125,15 @@ module.exports = {
       rules: {
         // https://github.com/jest-community/eslint-plugin-jest
         'jest/no-focused-tests': ERROR,
-      }
-    }
+      },
+    },
+
+    {
+      files: ['scripts/**/*.js', '**/__tests__/*.js'],
+      rules: {
+        'react-internal/static-error-messages': OFF,
+      },
+    },
   ],
 
   globals: {

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -1301,6 +1301,7 @@ function toPropertyAccessString(node) {
     const property = toPropertyAccessString(node.property);
     return `${object}.${property}`;
   } else {
+    // extract-errors/skip
     throw new Error(`Unsupported node type: ${node.type}`);
   }
 }

packages/react-dom/src/shared/ReactControlledValuePropTypes.js

@@ -38,6 +38,7 @@ if (__DEV__) {
       ) {
         return null;
       }
+      // extract-errors/skip
       return new Error(
         'You provided a `value` prop to a form field without an ' +
           '`onChange` handler. This will render a read-only field. If ' +
@@ -54,6 +55,7 @@ if (__DEV__) {
       ) {
         return null;
       }
+      // extract-errors/skip
       return new Error(
         'You provided a `checked` prop to a form field without an ' +
           '`onChange` handler. This will render a read-only field. If ' +

packages/react-dom/src/test-utils/ReactTestUtils.js

@@ -269,6 +269,7 @@ const ReactTestUtils = {
       className,
     );
     if (all.length !== 1) {
+      // extract-errors/skip
       throw new Error(
         'Did not find exactly one match (found: ' +
           all.length +
@@ -305,6 +306,7 @@ const ReactTestUtils = {
     validateClassInstance(root, 'findRenderedDOMComponentWithTag');
     const all = ReactTestUtils.scryRenderedDOMComponentsWithTag(root, tagName);
     if (all.length !== 1) {
+      // extract-errors/skip
       throw new Error(
         'Did not find exactly one match (found: ' +
           all.length +
@@ -340,6 +342,7 @@ const ReactTestUtils = {
       componentType,
     );
     if (all.length !== 1) {
+      // extract-errors/skip
       throw new Error(
         'Did not find exactly one match (found: ' +
           all.length +

packages/react-native-renderer/src/NativeMethodsMixinUtils.js

@@ -49,19 +49,18 @@ export function throwOnStylesProp(component: any, props: any) {
   if (props.styles !== undefined) {
     const owner = component._owner || null;
     const name = component.constructor.displayName;
-    let msg =
-      '`styles` is not a supported property of `' +
-      name +
-      '`, did ' +
-      'you mean `style` (singular)?';
+    let addendum = '';
     if (owner && owner.constructor && owner.constructor.displayName) {
-      msg +=
+      addendum +=
         '\n\nCheck the `' +
         owner.constructor.displayName +
         '` parent ' +
         ' component.';
     }
-    throw new Error(msg);
+    throw new Error(
+      `\`styles\` is not a supported property of \`${name}\`, did you ` +
+        `mean \`style\` (singular)?${addendum}`,
+    );
   }
 }
 

packages/react-noop-renderer/src/createReactNoop.js

@@ -113,6 +113,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof parentInstance.rootID !== 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error(
         'appendChildToContainer() first argument is not a container.',
       );
@@ -127,6 +128,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof (parentInstance: any).rootID === 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error('appendChild() first argument is not an instance.');
     }
     appendChildToContainerOrInstance(parentInstance, child);
@@ -143,6 +145,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     }
     const beforeIndex = parentInstance.children.indexOf(beforeChild);
     if (beforeIndex === -1) {
+      // extract-errors/skip
       throw new Error('This child does not exist.');
     }
     parentInstance.children.splice(beforeIndex, 0, child);
@@ -156,6 +159,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof parentInstance.rootID !== 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error(
         'insertInContainerBefore() first argument is not a container.',
       );
@@ -171,6 +175,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof (parentInstance: any).rootID === 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error('insertBefore() first argument is not an instance.');
     }
     insertInContainerOrInstanceBefore(parentInstance, child, beforeChild);
@@ -182,6 +187,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
   ): void {
     const index = parentInstance.children.indexOf(child);
     if (index === -1) {
+      // extract-errors/skip
       throw new Error('This child does not exist.');
     }
     parentInstance.children.splice(index, 1);
@@ -194,6 +200,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof parentInstance.rootID !== 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error(
         'removeChildFromContainer() first argument is not a container.',
       );
@@ -208,6 +215,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
     if (typeof (parentInstance: any).rootID === 'string') {
       // Some calls to this aren't typesafe.
       // This helps surface mistakes in tests.
+      // extract-errors/skip
       throw new Error('removeChild() first argument is not an instance.');
     }
     removeChildFromContainerOrInstance(parentInstance, child);
@@ -252,6 +260,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
 
   function shouldSetTextContent(type: string, props: Props): boolean {
     if (type === 'errorInBeginPhase') {
+      // extract-errors/skip
       throw new Error('Error in host config.');
     }
     return (
@@ -320,6 +329,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
       hostContext: HostContext,
     ): Instance {
       if (type === 'errorInCompletePhase') {
+        // extract-errors/skip
         throw new Error('Error in host config.');
       }
       const inst = {
@@ -368,12 +378,15 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
       newProps: Props,
     ): null | {} {
       if (type === 'errorInCompletePhase') {
+        // extract-errors/skip
         throw new Error('Error in host config.');
       }
       if (oldProps === null) {
+        // extract-errors/skip
         throw new Error('Should have old props');
       }
       if (newProps === null) {
+        // extract-errors/skip
         throw new Error('Should have new props');
       }
       hostDiffCounter++;
@@ -510,6 +523,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
           newProps: Props,
         ): void {
           if (oldProps === null) {
+            // extract-errors/skip
             throw new Error('Should have old props');
           }
           hostUpdateCounter++;

packages/react-reconciler/src/ReactFiberUnwindWork.js

@@ -373,14 +373,17 @@ function throwException(
       workInProgress = workInProgress.return;
     } while (workInProgress !== null);
     // No boundary was found. Fallthrough to error mode.
-    // TODO: Use invariant so the message is stripped in prod?
+
+    // TODO: The stack should be provided as a dev warning, but not an error, so
+    // it doesn't add to the production build.
+    const componentName =
+      getComponentName(sourceFiber.type) || 'A React component';
+    const componentStack = getStackByFiberInDevAndProd(sourceFiber);
     value = new Error(
-      (getComponentName(sourceFiber.type) || 'A React component') +
-        ' suspended while rendering, but no fallback UI was specified.\n' +
-        '\n' +
+      `${componentName} suspended while rendering, but no fallback UI ` +
+        'was specified.\n\n' +
         'Add a <Suspense fallback=...> component higher in the tree to ' +
-        'provide a loading indicator or placeholder to display.' +
-        getStackByFiberInDevAndProd(sourceFiber),
+        `provide a loading indicator or placeholder to display.${componentStack}`,
     );
   }
 

packages/react-test-renderer/src/ReactTestRenderer.js

@@ -111,6 +111,7 @@ function toJSON(inst: Instance | TextInstance): ReactTestRendererNode | null {
       return json;
     }
     default:
+      // extract-errors/skip
       throw new Error(`Unexpected node type in toJSON: ${inst.tag}`);
   }
 }
@@ -406,6 +407,7 @@ function expectOne(
       ? 'No instances found '
       : `Expected 1 but found ${all.length} instances `;
 
+  // extract-errors/skip
   throw new Error(prefix + message);
 }
 
@@ -524,10 +526,12 @@ const ReactTestRendererFiber = {
         enumerable: true,
         get: function() {
           if (root === null) {
+            // extract-errors/skip
             throw new Error("Can't access .root on unmounted test renderer");
           }
           const children = getChildren(root.current);
           if (children.length === 0) {
+            // extract-errors/skip
             throw new Error("Can't access .root on unmounted test renderer");
           } else if (children.length === 1) {
             // Normally, we skip the root and just give you the child.
@@ -566,6 +570,7 @@ function wrapFiber(fiber: Fiber): ReactTestInstance {
 // Enable ReactTestRenderer to be used to test DevTools integration.
 injectIntoDevTools({
   findFiberByHostInstance: (() => {
+    // extract-errors/skip
     throw new Error('TestRenderer does not support findFiberByHostInstance()');
   }: any),
   bundleType: __DEV__ ? 1 : 0,

packages/scheduler/src/forks/SchedulerHostConfig.mock.js

@@ -49,6 +49,7 @@ export function getCurrentTime(): number {
 
 export function reset() {
   if (isFlushing) {
+    // extract-errors/skip
     throw new Error('Cannot reset while already flushing work.');
   }
   currentTime = 0;
@@ -63,6 +64,7 @@ export function reset() {
 // Should only be used via an assertion helper that inspects the yielded values.
 export function unstable_flushNumberOfYields(count: number): void {
   if (isFlushing) {
+    // extract-errors/skip
     throw new Error('Already flushing work.');
   }
   expectedNumberOfYields = count;
@@ -85,6 +87,7 @@ export function unstable_flushNumberOfYields(count: number): void {
 
 export function unstable_flushExpired() {
   if (isFlushing) {
+    // extract-errors/skip
     throw new Error('Already flushing work.');
   }
   if (scheduledCallback !== null) {
@@ -101,6 +104,7 @@ export function unstable_flushExpired() {
 
 export function unstable_flushWithoutYielding(): void {
   if (isFlushing) {
+    // extract-errors/skip
     throw new Error('Already flushing work.');
   }
   isFlushing = true;
@@ -131,13 +135,15 @@ export function unstable_clearYields(): Array<mixed> {
 
 export function flushAll(): void {
   if (yieldedValues !== null) {
+    // extract-errors/skip
     throw new Error(
       'Log is not empty. Assert on the log of yielded values before ' +
         'flushing additional work.',
     );
   }
   unstable_flushWithoutYielding();
   if (yieldedValues !== null) {
+    // extract-errors/skip
     throw new Error(
       'While flushing work, something yielded a value. Use an ' +
         'assertion helper to assert on the log of yielded values, e.g. ' +

packages/shared/ReactError.js

@@ -11,6 +11,7 @@
 // build, and in production they will be minified.
 
 function ReactError(message) {
+  // extract-errors/skip
   const error = new Error(message);
   error.name = 'Invariant Violation';
   return error;

packages/shared/ReactErrorProd.js

@@ -15,6 +15,7 @@ function ReactErrorProd(code) {
   for (let i = 1; i < arguments.length; i++) {
     url += '&args[]=' + encodeURIComponent(arguments[i]);
   }
+  // extract-errors/skip
   return new Error(
     `Minified React error #${code}; visit ${url} for the full message or ` +
       'use the non-minified dev environment for full errors and additional ' +

packages/shared/ReactFeatureFlags.js

@@ -38,9 +38,7 @@ export const enableSuspenseServerRenderer = false; // TODO: __DEV__? Here it mig
 export const enableSchedulerDebugging = false;
 
 // Only used in www builds.
-export function addUserTimingListener() {
-  throw new Error('Not implemented.');
-}
+export function addUserTimingListener() {}
 
 // Disable javascript: URL strings in href for XSS protection.
 export const disableJavaScriptURLs = false;

packages/shared/invariant.js

@@ -18,6 +18,7 @@
  */
 
 export default function invariant(condition, format, a, b, c, d, e, f) {
+  // extract-errors/skip
   throw new Error(
     'Internal React error: invariant() is meant to be replaced at compile ' +
       'time. There is no runtime version.',

packages/shared/invokeGuardedCallbackImpl.js

@@ -186,6 +186,7 @@ if (__DEV__) {
       if (didError) {
         if (!didSetError) {
           // The callback errored, but the error event never fired.
+          // extract-errors/skip
           error = new Error(
             'An error was thrown inside one of your components, but React ' +
               "doesn't know what it was. This is likely due to browser " +
@@ -197,6 +198,7 @@ if (__DEV__) {
               'actually an issue with React, please file an issue.',
           );
         } else if (isCrossOriginError) {
+          // extract-errors/skip
           error = new Error(
             "A cross-origin error was thrown. React doesn't have access to " +
               'the actual error object in development. ' +

packages/shared/lowPriorityWarning.js

@@ -32,12 +32,14 @@ if (__DEV__) {
       // --- Welcome to debugging React ---
       // This error was thrown as a convenience so that you can use this stack
       // to find the callsite that caused this warning to fire.
+      // extract-errors/skip
       throw new Error(message);
     } catch (x) {}
   };
 
   lowPriorityWarning = function(condition, format, ...args) {
     if (format === undefined) {
+      // extract-errors/skip
       throw new Error(
         '`lowPriorityWarning(condition, format, ...args)` requires a warning ' +
           'message argument',