Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds React event component and React event target support to SSR renderer #15242

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Adds React event component and React event target support to SSR renderer #15242

merged 3 commits into from
Mar 28, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 28, 2019 •
edited
Loading

Note: this is for an experimental event API that we're testing out internally at Facebook.

This PR adds support for server side rendering for the experimental event API along with tests. I also added some ReactDOM renderer tests to the same test file to be consistent and give more coverage.

#15036
#15112
#15150
#15168
#15179
#15228

@trueadm trueadm requested a review from sebmarkbage March 28, 2019 18:02
@sizebot
Copy link

sizebot commented Mar 28, 2019 •
edited
Loading

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: fb6b508...841ca0f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% -0.0% 813.02 KB 813.02 KB 184.14 KB 184.14 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 105.12 KB 105.12 KB 33.97 KB 33.97 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 108.09 KB 108.09 KB 34.63 KB 34.63 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 807.41 KB 807.41 KB 182.54 KB 182.54 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 105.09 KB 105.09 KB 33.48 KB 33.47 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 108.19 KB 108.19 KB 34.08 KB 34.08 KB NODE_PROFILING
ReactDOM-dev.js 0.0% -0.0% 832.11 KB 832.11 KB 184.17 KB 184.17 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 330.96 KB 330.96 KB 60.97 KB 60.97 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% -0.0% 337.35 KB 337.35 KB 62.33 KB 62.33 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% -0.0% 813.36 KB 813.36 KB 184.28 KB 184.28 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.13 KB 105.13 KB 33.98 KB 33.98 KB UMD_PROD
react-dom-unstable-fire.development.js 0.0% -0.0% 807.75 KB 807.75 KB 182.68 KB 182.67 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 105.11 KB 105.11 KB 33.48 KB 33.48 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 108.21 KB 108.21 KB 34.09 KB 34.09 KB NODE_PROFILING
ReactFire-dev.js 0.0% -0.0% 831.32 KB 831.32 KB 184.1 KB 184.1 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 47.49 KB 47.49 KB 12.98 KB 12.98 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 9.95 KB 9.95 KB 3.66 KB 3.65 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 47.21 KB 47.21 KB 12.91 KB 12.91 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 9.73 KB 9.73 KB 3.59 KB 3.58 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.74 KB 60.74 KB 15.84 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.69 KB 10.69 KB 3.67 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.41 KB 60.41 KB 15.72 KB 15.71 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.42 KB 10.42 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-server.browser.development.js +0.8% +0.4% 133.68 KB 134.78 KB 35.37 KB 35.51 KB UMD_DEV
react-dom-server.browser.production.min.js 🔺+0.6% 🔺+0.6% 18.93 KB 19.05 KB 7.14 KB 7.18 KB UMD_PROD
react-dom-server.browser.development.js +0.9% +0.4% 129.81 KB 130.91 KB 34.43 KB 34.57 KB NODE_DEV
react-dom-server.browser.production.min.js 🔺+0.6% 🔺+0.5% 18.86 KB 18.98 KB 7.14 KB 7.17 KB NODE_PROD
ReactDOMServer-dev.js +0.8% +0.4% 132.15 KB 133.24 KB 34.19 KB 34.32 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+1.3% 🔺+0.7% 45.67 KB 46.27 KB 10.56 KB 10.64 KB FB_WWW_PROD
react-dom-server.node.development.js +0.8% +0.4% 131.75 KB 132.86 KB 34.97 KB 35.12 KB NODE_DEV
react-dom-server.node.production.min.js 🔺+0.6% 🔺+0.5% 19.72 KB 19.84 KB 7.44 KB 7.48 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 706 B 704 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 637 B 636 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD

Generated by 🚫 dangerJS

trueadm
trueadm commented Mar 28, 2019
View reviewed changes
packages/react-reconciler/src/__tests__/ReactFiberEvents-test-internal.js
@@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*
* @emails react-core
* @jest-environment node
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This existed from a copy and paste from a previous test file. We don't want it here as we want Jest to give the JSDOM for document and using this setting removes JSDOM support for this test.

sebmarkbage
sebmarkbage approved these changes Mar 28, 2019
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let's throw if not enabled.

@trueadm trueadm merged commit c6f3524 into facebook:master Mar 28, 2019
@trueadm trueadm deleted the add-react-event-types-to-ssr branch March 28, 2019 22:36
@trueadm trueadm mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @sebmarkbage @facebook-github-bot