Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix longpress in experimental Press event module #15246

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 28, 2019

The longpress event is dispatched during a press interaction, rather than after it has ended.

The longPressCancelsPress prop can be used to prevent 'press' being dispatched if longpress has already been dispatched.

The 'longpress' event is dispatched during a press interaction, rather than
after it has ended.

The 'longPressCancelsPress' prop can be used to prevent 'press' being
dispatched if 'longpress' has already been dispatched.
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the typo on the comment.

@sizebot
Copy link

sizebot commented Mar 28, 2019

Details of bundled changes.

Comparing: fb6b508...981463d

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% +0.2% 1.16 KB 1.16 KB 618 B 619 B UMD_DEV
react-events.production.min.js 0.0% 🔺+0.2% 682 B 682 B 431 B 432 B UMD_PROD
react-events.development.js 0.0% +0.2% 996 B 996 B 556 B 557 B NODE_DEV
react-events.production.min.js 0.0% 🔺+0.6% 512 B 512 B 353 B 355 B NODE_PROD
react-events-press.development.js -3.9% -0.9% 9.92 KB 9.53 KB 2.42 KB 2.4 KB UMD_DEV
react-events-press.production.min.js -3.5% -1.0% 4.08 KB 3.93 KB 1.41 KB 1.39 KB UMD_PROD
react-events-press.development.js -3.9% -0.9% 9.75 KB 9.36 KB 2.38 KB 2.36 KB NODE_DEV
react-events-press.production.min.js -3.7% -0.9% 3.91 KB 3.77 KB 1.35 KB 1.34 KB NODE_PROD
ReactEventsPress-dev.js -4.8% -1.6% 9.97 KB 9.5 KB 2.41 KB 2.37 KB FB_WWW_DEV
ReactEventsPress-prod.js -6.5% -1.2% 8.18 KB 7.65 KB 1.74 KB 1.71 KB FB_WWW_PROD
react-events-hover.production.min.js 0.0% 🔺+0.2% 2.12 KB 2.12 KB 903 B 905 B UMD_PROD
react-events-hover.production.min.js 0.0% 🔺+0.1% 1.95 KB 1.95 KB 846 B 847 B NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 700f17b into facebook:master Mar 29, 2019
@necolas necolas deleted the react-events/long-press branch May 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants