-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EventComponent logic + add onOwnershipChange callback #15354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 29fb586...96dd7cb react-dom
Generated by 🚫 dangerJS |
threepointone
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does feel like it has more clarity and less futzing with fibers. approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is for the experimental event API
This PR does a bunch of things. The changes are mostly cosmetic tidy ups that simplify patterns and remove the exposure of internal fiber data structures, but also this PR adds a new feature (
onOwnershipChange
). Specifically:onOwnershipChange
. When a responder module requests ownership, responders can opt into listening for a change in ownership – to allow for cleanup of events. Ownership is tracked via aSet
.handleEventComponent
callback in renderers to be two separate callbacks:mountEventComponent
andupdateEventComponent
, so things are more consistent.onOwnershipChange
working.