[Suspense] Use style.setProperty to set display #15882
Conversation
Follow up to facebook#15861. Turns out you can't set `!important` using a normal property assignment. You have to use `style.setProperty`. Maybe Andrew *should* just learn CSS. IE9 doesn't support `style.setProperty` so we'll fall back to setting `display: none` without `important`, like we did before facebook#15861 Our advice for apps that need to support IE9 will be to avoid using `!important`. Which seems like good advice in general, but IANACSSE. Tested on FB and using our Suspense DOM fixture.
| @@ -83,25 +83,25 @@ describe('ReactDOMSuspensePlaceholder', () => { | |||
| <div ref={divs[1]}> | |||
| <AsyncText ms={500} text="B" /> | |||
| </div> | |||
| <div style={{display: 'block'}} ref={divs[2]}> | |||
| <div style={{display: 'span'}} ref={divs[2]}> | |||
There was a problem hiding this comment.
?
Maybe you should learn some CSS.
There was a problem hiding this comment.
I changed it to span since block is the default display for divs.
There was a problem hiding this comment.
Ahaha I meant inline.
There was a problem hiding this comment.
I was talking to my brain, not you.
There was a problem hiding this comment.
This week's episode of "Andrew talks to himself" brought to you by the React team
There was a problem hiding this comment.
But !important only accept from style.setProperty is really first time killer except holder of CSS degree😅
Thanks find out this @acdlite 😀
There was a problem hiding this comment.
Following up Andrew to learn CSS. 😄
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
acdlite
force-pushed
the
use-style-setproperty
branch
from
52240a6
to
338eab2
Compare
|
@threepointone approved these changes 6 days ago 👀, so maybe it's not your fault Andrew(nice explanation!) |
Follow up to facebook#15861. Turns out you can't set `!important` using a normal property assignment. You have to use `style.setProperty`. Maybe Andrew *should* just learn CSS. IE9 doesn't support `style.setProperty` so we'll fall back to setting `display: none` without `important`, like we did before facebook#15861 Our advice for apps that need to support IE9 will be to avoid using `!important`. Which seems like good advice in general, but IANACSSE. Tested on FB and using our Suspense DOM fixture.
Follow up to #15861.
Turns out you can't set
!importantusing a normal property assignment. You have to usestyle.setProperty.Maybe Andrew should just learn CSS.
IE9 doesn't support
style.setPropertyso we'll fall back to settingdisplay: nonewithoutimportant, like we did before #15861. Our advice for apps that need to support IE9 will be to avoid using!important. Which seems like good advice in general, but IANACSSE.Tested on FB and using our Suspense DOM fixture.