Don't hyphenate custom CSS properties for ReactDOMServer #16167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedakb
changed the title
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
arianon
reviewed
Jul 20, 2019
|
Please add a test to one of |
|
@gaearon updated. |
gaearon
reviewed
Jul 26, 2019
| @@ -212,7 +212,8 @@ const processStyleName = function(styleName) { | |||
| if (styleNameCache.hasOwnProperty(styleName)) { | |||
| return styleNameCache[styleName]; | |||
| } | |||
| const result = hyphenateStyleName(styleName); | |||
| const isCustomProperty = styleName.indexOf('--') === 0; | |||
There was a problem hiding this comment.
It's not ideal that we do this check again because createMarkupForStyles which calls us already does the same check anyway.
|
Looks good to me. Thanks. |
Merged
This was referenced Aug 17, 2019
This was referenced Mar 10, 2020
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16160